[
https://issues.apache.org/jira/browse/HIVE-4927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-4927:
------------------------------
Attachment: HIVE-4927.D11811.2.patch
yhuai updated the revision "HIVE-4927 [jira] When we merge two MapJoin
MapRedTasks, the TableScanOperator of the second one should be removed".
- update results
Reviewers: JIRA
REVISION DETAIL
https://reviews.facebook.net/D11811
CHANGE SINCE LAST DIFF
https://reviews.facebook.net/D11811?vs=36141&id=36183#toc
AFFECTED FILES
data/files/v1.txt
data/files/v2.txt
hcatalog/build-support/ant/checkstyle.xml
metastore/src/model/package.jdo
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java
ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java
ql/src/test/results/clientpositive/auto_join13.q.out
ql/src/test/results/clientpositive/auto_join2.q.out
ql/src/test/results/clientpositive/auto_join22.q.out
ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out
ql/src/test/results/clientpositive/join28.q.out
ql/src/test/results/clientpositive/join32.q.out
ql/src/test/results/clientpositive/join33.q.out
ql/src/test/results/clientpositive/join_star.q.out
ql/src/test/results/clientpositive/mapjoin_mapjoin.q.out
ql/src/test/results/clientpositive/mapjoin_subquery.q.out
ql/src/test/results/clientpositive/mapjoin_subquery2.q.out
ql/src/test/results/clientpositive/multiMapJoin1.q.out
ql/src/test/results/clientpositive/multi_join_union.q.out
testutils/ptest2/README.md
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/request/TestStartRequest.java
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/ExecutionPhase.java
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/HostExecutor.java
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/JIRAService.java
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/JUnitReportParser.java
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/ReportingPhase.java
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/QFileTestBatch.java
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/UnitTestBatch.java
testutils/ptest2/src/main/resources/batch-exec.vm
testutils/ptest2/src/main/resources/source-prep.vm
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestExecutionPhase.java
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestHostExecutor.java
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestReportParser.java
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestReportingPhase.testExecute.approved.txt
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestScripts.java
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestScripts.testBatch.approved.txt
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestScripts.testPrepGit.approved.txt
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestScripts.testPrepNone.approved.txt
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestScripts.testPrepSvn.approved.txt
testutils/ptest2/src/test/resources/SomeTest-failure.xml
testutils/ptest2/src/test/resources/TEST-SomeTest-failure.xml
testutils/ptest2/src/test/resources/SomeTest-success.xml
testutils/ptest2/src/test/resources/test-outputs/TEST-SomeTest-truncated.xml
testutils/ptest2/src/test/resources/test-outputs/SomeTest-truncated.xml
testutils/ptest2/src/test/resources/test-outputs/TEST-index_auth.q-bucketcontex-ba31fb54-1d7f-4c70-a89d-477b7d155191-TEST-org.apache.hadoop.hive.cli.TestCliDriver.xml
testutils/ptest2/src/test/resources/test-outputs/TEST-skewjoin.q-ab8536a7-1b5c-45ed-ba29-14450f27db8b-TEST-org.apache.hadoop.hive.cli.TestCliDriver.xml
testutils/ptest2/src/test/resources/test-outputs/TEST-skewjoin_union_remove_1.q-6fa31776-d2b0-4e13-9761-11f750627ad1-TEST-org.apache.hadoop.hive.cli.TestCliDriver.xml
testutils/ptest2/src/test/resources/test-outputs/TEST-union_remove_9.q-acb9de8f-1b9c-4874-924c-b2107ca7b07c-TEST-org.apache.hadoop.hive.cli.TestCliDriver.xml
testutils/ptest2/src/test/resources/test-outputs/index_auth.q-TEST-org.apache.hadoop.hive.cli.TestCliDriver.xml
testutils/ptest2/src/test/resources/test-outputs/index_auth.q-bucketcontex-ba31fb54-1d7f-4c70-a89d-477b7d155191-hive.log
testutils/ptest2/src/test/resources/test-outputs/index_auth.q-hive.log
testutils/ptest2/src/test/resources/test-outputs/skewjoin.q-TEST-org.apache.hadoop.hive.cli.TestCliDriver.xml
testutils/ptest2/src/test/resources/test-outputs/skewjoin.q-ab8536a7-1b5c-45ed-ba29-14450f27db8b-TestCliDriver.txt
testutils/ptest2/src/test/resources/test-outputs/skewjoin.q-ab8536a7-1b5c-45ed-ba29-14450f27db8b-hive.log
testutils/ptest2/src/test/resources/test-outputs/skewjoin_union_remove_1.q-6fa31776-d2b0-4e13-9761-11f750627ad1-TestCliDriver.txt
testutils/ptest2/src/test/resources/test-outputs/skewjoin_union_remove_1.q-6fa31776-d2b0-4e13-9761-11f750627ad1-hive.log
testutils/ptest2/src/test/resources/test-outputs/skewjoin_union_remove_1.q-TEST-org.apache.hadoop.hive.cli.TestCliDriver.xml
testutils/ptest2/src/test/resources/test-outputs/skewjoin_union_remove_1.q-TestCliDriver.txt
testutils/ptest2/src/test/resources/test-outputs/union_remove_9.q-TEST-org.apache.hadoop.hive.cli.TestCliDriver.xml
testutils/ptest2/src/test/resources/test-outputs/union_remove_9.q-acb9de8f-1b9c-4874-924c-b2107ca7b07c-TestCliDriver.txt
testutils/ptest2/src/test/resources/test-outputs/union_remove_9.q-acb9de8f-1b9c-4874-924c-b2107ca7b07c-hive.log
To: JIRA, yhuai
> When we merge two MapJoin MapRedTasks, the TableScanOperator of the second
> one should be removed
> ------------------------------------------------------------------------------------------------
>
> Key: HIVE-4927
> URL: https://issues.apache.org/jira/browse/HIVE-4927
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.12.0
> Reporter: Yin Huai
> Assignee: Yin Huai
> Attachments: HIVE-4927.D11811.1.patch, HIVE-4927.D11811.2.patch
>
>
> {code}
> set hive.auto.convert.join=true;
> set hive.auto.convert.join.noconditionaltask=true;
> EXPLAIN
> SELECT x1.key AS key FROM src x1 JOIN src1 y1 ON (x1.key = y1.key) JOIN src1
> y2 ON (x1.value = y2.value) GROUP BY x1.key;
> {\code}
> We will get a NPE from MetadataOnlyOptimizer. The reason is that the operator
> tree of the MapRedTask evaluating two MapJoins is
> {code}
> TS1->MapJoin1->TS2->MapJoin2->...
> {\code}
> We should remove the TS2...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
