[ 
https://issues.apache.org/jira/browse/HIVE-4806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717959#comment-13717959
 ] 

Matt Burgess commented on HIVE-4806:
------------------------------------

Alan,

Thanks for the feedback! I will incorporate them and submit a new patch, here 
are a few notes:

- HiveConnection.setReadOnly - Oops! I blindly applied my Hive 1 changes across 
to Hive 2. If HS2 supports both modes, I will update the patch to maintain the 
appropriate state.

- HiveDatabaseMetaData.supportsResultSetConcurrency - I have not tested this 
but I will try, do you know of existing test scripts that would educe this 
behavior? Alternatively, is it more appropriate to return false for Hive / HS2?

- HiveResultsSetMetaData.getColumnTypeName - I'm not really sure about these, I 
inherited a bit of this code. I did find references in MetaStoreUtils: 
https://github.com/apache/hive/blob/075e02ea6de25958de2820d73b7865e7f9d56189/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java

but I'm not sure this is germane to HiveResultsSetMetaData. I can surely remove 
these if appropriate to do so.

                
> Add more implementations of JDBC API methods to Hive and Hive2 drivers
> ----------------------------------------------------------------------
>
>                 Key: HIVE-4806
>                 URL: https://issues.apache.org/jira/browse/HIVE-4806
>             Project: Hive
>          Issue Type: Improvement
>          Components: JDBC
>    Affects Versions: 0.11.0
>            Reporter: Matt Burgess
>             Fix For: 0.12.0
>
>         Attachments: HIVE-4806.patch
>
>
> Third-party client software such as Pentaho Data Integration (PDI) uses many 
> different JDBC API calls when interacting with JDBC data sources. Several of 
> these calls have not yet been implemented in the Hive and Hive 2 drivers and 
> by default will throw "Method not supported" SQLExceptions when there could 
> be default implementations instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to