[ 
https://issues.apache.org/jira/browse/HIVE-4900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13715465#comment-13715465
 ] 

Xuefu Zhang commented on HIVE-4900:
-----------------------------------

Apparently we cannot remove "SORT_ORDER" section of package.jdo, even if all 
instances will be embedded. This is demonstrated in DN example: 
http://www.datanucleus.org/products/accessplatform/jdo/orm/embedded.html#Collection.

What is missing in original package.jdo is the "comment" field in MFieldSchema 
isn't mapped to a COLUMN in some tables: TYPE_FIELDS and COLUMNS_V2. However, 
there was a mapping in table PARTITION_KEYS. Old DN didn't complain, but the 
3.2 DN does.

So, the fix is simply following what's done for PARTITION_KEYS:

I have tested the new patch with the new DN and no test fails. The next test 
result will have a say how it goes with the old DN.

I also tested mysql with "create table", which will fail w/o this patch.
                
> Fix the mismatched column names in package.jdo
> ----------------------------------------------
>
>                 Key: HIVE-4900
>                 URL: https://issues.apache.org/jira/browse/HIVE-4900
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 0.10.0, 0.11.0
>            Reporter: Xuefu Zhang
>            Assignee: Xuefu Zhang
>            Priority: Minor
>             Fix For: 0.12.0
>
>         Attachments: HIVE-4900.1.patch, HIVE-4900.2.patch, HIVE-4900.patch
>
>
> There are several errors in DataNucleus O-R mapping file, package.jdo, which 
> are not complained by the existing DN version. These errors may be subject to 
> future DN complaint (as experienced in HIVE-3632 and HIVE-2084). However, it 
> is still better if we fix these errors as it also creates some confusion in 
> the community.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to