[
https://issues.apache.org/jira/browse/HIVE-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702789#comment-13702789
]
Hudson commented on HIVE-3810:
------------------------------
Integrated in Hive-trunk-hadoop1-ptest #47 (See
[https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/47/])
HIVE-3810 : HiveHistory.log need to replace \r with space before writing
Entry.value to historyfile (Mark Grover via Ashutosh Chauhan) (Revision 1500991)
Result = FAILURE
hashutosh :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1500991
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java
> HiveHistory.log need to replace '\r' with space before writing Entry.value to
> historyfile
> -----------------------------------------------------------------------------------------
>
> Key: HIVE-3810
> URL: https://issues.apache.org/jira/browse/HIVE-3810
> Project: Hive
> Issue Type: Bug
> Components: Logging
> Reporter: qiangwang
> Assignee: Mark Grover
> Priority: Minor
> Fix For: 0.12.0
>
> Attachments: HIVE-3810.1.patch, HIVE-3810.2.patch, HIVE-3810.3.patch,
> HIVE-3810.4.patch
>
>
> HiveHistory.log will replace '\n' with space before writing Entry.value to
> history file:
> val = val.replace('\n', ' ');
> but HiveHistory.parseHiveHistory use BufferedReader.readLine which takes
> '\n', '\r', '\r\n' as line delimiter to parse history file
> if val contains '\r', there is a high possibility that HiveHistory.parseLine
> will fail, in which case usually RecordTypes.valueOf(recType) will throw
> exception 'java.lang.IllegalArgumentException'
> HiveHistory.log need to replace '\r' with space as well:
> val = val.replace('\n', ' ');
> changed to
> val = val.replaceAll("\r|\n", " ");
> or
> val = val.replace('\r', ' ').replace('\n', ' ');
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
