----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11865/#review22750 -----------------------------------------------------------
Ship it! +1 Looks good - Thejas Nair On July 4, 2013, 1:46 a.m., Eugene Koifman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11865/ > ----------------------------------------------------------- > > (Updated July 4, 2013, 1:46 a.m.) > > > Review request for hive, Ashutosh Chauhan and Thejas Nair. > > > Bugs: HIVE-4580 > https://issues.apache.org/jira/browse/HIVE-4580 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-4580?focusedCommentId=13681842&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13681842 > has a description of this change > > > Diffs > ----- > > contrib/src/test/results/clientnegative/serde_regex.q.out c51567f > contrib/src/test/results/clientnegative/url_hook.q.out a4aa64f > hcatalog/src/test/e2e/templeton/tests/ddl.conf 518a94c > > hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/AppConfig.java > 7bf9ede > > hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/BadParam.java > d734a30 > > hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/BusyException.java > c9a04ab > > hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/CallbackFailedException.java > fb6a422 > > hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/CatchallExceptionMapper.java > 3ff570f > > hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/HcatDelegator.java > 6dbf9e2 > > hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/HcatException.java > 388578a > > hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/JsonBuilder.java > 55be07a > hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/Main.java > c074452 > > hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/NotAuthorizedException.java > 3ebae20 > > hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/QueueException.java > a7f35f9 > > hcatalog/webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestWebHCatE2e.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/Driver.java a5a867a > ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java c796770 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 295daab > ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java 17387a9 > ql/src/java/org/apache/hadoop/hive/ql/exec/TaskResult.java 26d2c33 > ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java fcf9adc > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 17daaa1 > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveException.java f544034 > ql/src/java/org/apache/hadoop/hive/ql/metadata/InvalidTableException.java > 10d00e7 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java > e24f5f9 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java > b08fb76 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java > 6632afe > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java > 97857f4 > ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java 9fc52fa > ql/src/test/results/clientnegative/add_partition_with_whitelist.q.out > 67dca5a > ql/src/test/results/clientnegative/addpart1.q.out f4da8f1 > ql/src/test/results/clientnegative/alter_partition_nodrop_table.q.out > 3117392 > ql/src/test/results/clientnegative/alter_partition_with_whitelist.q.out > a094f24 > ql/src/test/results/clientnegative/alter_rename_partition_failure.q.out > da6401f > ql/src/test/results/clientnegative/alter_rename_partition_failure2.q.out > 1bda93e > ql/src/test/results/clientnegative/alter_rename_partition_failure3.q.out > 72feb31 > ql/src/test/results/clientnegative/alter_table_wrong_regex.q.out e634648 > ql/src/test/results/clientnegative/alter_view_failure4.q.out ab7f0ee > ql/src/test/results/clientnegative/altern1.q.out c52ca04 > ql/src/test/results/clientnegative/archive1.q.out 03b309e > ql/src/test/results/clientnegative/archive2.q.out 6a942fd > ql/src/test/results/clientnegative/archive_multi1.q.out 7153965 > ql/src/test/results/clientnegative/archive_multi2.q.out 5362df3 > ql/src/test/results/clientnegative/archive_multi3.q.out af6c3f9 > ql/src/test/results/clientnegative/archive_multi4.q.out 9a044fe > ql/src/test/results/clientnegative/archive_multi5.q.out 8832ed2 > ql/src/test/results/clientnegative/archive_multi6.q.out b6606e6 > ql/src/test/results/clientnegative/archive_multi7.q.out 9e27929 > ql/src/test/results/clientnegative/authorization_fail_1.q.out 020916f > ql/src/test/results/clientnegative/column_rename1.q.out 52961e1 > ql/src/test/results/clientnegative/column_rename2.q.out 0ca78f9 > ql/src/test/results/clientnegative/column_rename4.q.out e776034 > ql/src/test/results/clientnegative/create_table_failure3.q.out 2df2503 > ql/src/test/results/clientnegative/create_table_failure4.q.out d65196a > ql/src/test/results/clientnegative/create_table_wrong_regex.q.out be7ca05 > ql/src/test/results/clientnegative/create_view_failure1.q.out 27d4604 > ql/src/test/results/clientnegative/create_view_failure2.q.out fcae7f8 > ql/src/test/results/clientnegative/create_view_failure4.q.out 0c6a64c > ql/src/test/results/clientnegative/database_create_already_exists.q.out > 8fe3cc8 > ql/src/test/results/clientnegative/database_create_invalid_name.q.out > 1e58089 > ql/src/test/results/clientnegative/database_drop_does_not_exist.q.out > 56335b4 > ql/src/test/results/clientnegative/database_drop_not_empty.q.out baa8f37 > ql/src/test/results/clientnegative/database_drop_not_empty_restrict.q.out > b297a99 > ql/src/test/results/clientnegative/database_switch_does_not_exist.q.out > 8b5674d > ql/src/test/results/clientnegative/deletejar.q.out 4944fd9 > ql/src/test/results/clientnegative/describe_xpath1.q.out 3996e29 > ql/src/test/results/clientnegative/describe_xpath2.q.out aac33a8 > ql/src/test/results/clientnegative/describe_xpath3.q.out 2b66907 > ql/src/test/results/clientnegative/describe_xpath4.q.out 4297bcf > > ql/src/test/results/clientnegative/disallow_incompatible_type_change_on1.q.out > f44ace4 > > ql/src/test/results/clientnegative/disallow_incompatible_type_change_on2.q.out > 5af55b8 > ql/src/test/results/clientnegative/drop_table_failure2.q.out 809f16f > ql/src/test/results/clientnegative/drop_table_failure3.q.out 655bf41 > ql/src/test/results/clientnegative/drop_view_failure1.q.out 61ec927 > ql/src/test/results/clientnegative/external1.q.out 4f04777 > ql/src/test/results/clientnegative/external2.q.out 49652ff > ql/src/test/results/clientnegative/invalid_columns.q.out ccc17d9 > ql/src/test/results/clientnegative/lockneg2.q.out ea34746 > ql/src/test/results/clientnegative/lockneg3.q.out 0664348 > ql/src/test/results/clientnegative/lockneg4.q.out bd5ff83 > ql/src/test/results/clientnegative/lockneg5.q.out 083ef32 > ql/src/test/results/clientnegative/protectmode_tbl6.q.out 08a66ed > ql/src/test/results/clientnegative/protectmode_tbl_no_drop.q.out f41b12b > ql/src/test/results/clientnegative/serde_regex.q.out 1c5b5fa > ql/src/test/results/clientnegative/serde_regex3.q.out 88ae604 > ql/src/test/results/clientnegative/touch1.q.out 3f3c5e7 > ql/src/test/results/clientnegative/touch2.q.out b0b8826 > > Diff: https://reviews.apache.org/r/11865/diff/ > > > Testing > ------- > > WebHCat e2e, HCatalog unit tests, Hive TestNegativeCliDriver > > > Thanks, > > Eugene Koifman > >
