[
https://issues.apache.org/jira/browse/HIVE-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13691935#comment-13691935
]
Carl Steinbach commented on HIVE-4569:
--------------------------------------
@Jaideep: Thanks for posting an updated patch. I plan to spend some more time
tonight looking this over closely, but in the meantime I wanted to raise one
high-level concern. I think the HS2 Thrift API should be as self-contained as
possible. In particular I don't think it's a good idea to inherit functionality
from any of the quasi-public Thrift APIs that already exist (e.g.
queryplan.thrift) for the following reasons:
* We version the HS2 Thrift API in order to maintain backward compatibility
with older clients, and I'm worried that people will forget to bump the version
number in TCLIService.thrift when they make a change in queryplan.thrift.
* One of the original design goals of HS2 was to decouple the network
serialization layer from the service layer in the interest of eventually being
able to easily support multiple different serialization formats (e.g.
Protobufs, Avro, Thrift, etc). I think depending on queryplan.thrift will make
it harder to do this.
* At the moment TCLIService.thrift doesn't expose anything that ties it
directly to Hive, and I'd like to keep it that way. For example, there's no
reason why we couldn't also embed the Pig language runtime in HS2 and expose it
through the HS2 API (see the [AccessServer
proposal|https://cwiki.apache.org/confluence/display/Hive/AccessServer+Design+Proposal]
for more details). Tying the new QueryPlan RPC to queryplan.thrift will make
this harder to do.
Instead of depending on queryplan.thrift I'd like to propose that
TGetQueryPlanResp return a JSON or XML encoded version of the queryplan.
> GetQueryPlan api in Hive Server2
> --------------------------------
>
> Key: HIVE-4569
> URL: https://issues.apache.org/jira/browse/HIVE-4569
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
> Reporter: Amareshwari Sriramadasu
> Assignee: Jaideep Dhok
> Attachments: git-4569.patch, HIVE-4569.D10887.1.patch,
> HIVE-4569.D11469.1.patch
>
>
> It would nice to have GetQueryPlan as thrift api. I do not see GetQueryPlan
> api available in HiveServer2, though the wiki
> https://cwiki.apache.org/confluence/display/Hive/HiveServer2+Thrift+API
> contains, not sure why it was not added.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
