[ 
https://issues.apache.org/jira/browse/HIVE-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yin Huai resolved HIVE-3876.
----------------------------

    Resolution: Not A Problem

Sorry for not looking at it for a long time. I just took a look at the code. 
BytesRefArrayWritable is used by first "ensureCapacity" and then set "valid" in 
"resetValid" or "set". If we use "resetValid" in the constructor, we can get 
those elements which are not valid, which should not be allowed. Let's close it 
as "Not A Problem".
                
> call resetValid instead of ensureCapacity in the constructor of 
> BytesRefArrayWritable
> -------------------------------------------------------------------------------------
>
>                 Key: HIVE-3876
>                 URL: https://issues.apache.org/jira/browse/HIVE-3876
>             Project: Hive
>          Issue Type: Improvement
>          Components: Serializers/Deserializers
>    Affects Versions: 0.10.0
>            Reporter: Yin Huai
>            Assignee: Yin Huai
>            Priority: Minor
>         Attachments: HIVE-3876.1.patch.txt
>
>
> In the constructor of BytesRefArrayWritable, ensureCapacity(capacity) is 
> called, but "valid" has not been adjusted accordingly. After a new 
> BytesRefArrayWritable has been created with a initial capacity of "x", if 
> resetValid() has not been called explicitly, the size returned is still 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to