[ 
https://issues.apache.org/jira/browse/HIVE-4593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-4593:
------------------------------

    Attachment: HIVE-4593.D10965.1.patch

navis requested code review of "HIVE-4593 [jira] ErrorMsg has several messages 
that reuse the same error code".

Reviewers: JIRA

HIVE-4593 ErrorMsg has several messages that reuse the same error code

All of these errorCode values are associated with more than one message.
10043
10227
10228
10229
10230
10231

This is not right.

This affects ErrorMsg.getErrorMsg(int errorCode) as well as Templeton logic.

Should probably add a JUnit test to check this.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D10965

AFFECTED FILES
  ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java

MANAGE HERALD RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/26199/

To: JIRA, navis

                
> ErrorMsg has several messages that reuse the same error code
> ------------------------------------------------------------
>
>                 Key: HIVE-4593
>                 URL: https://issues.apache.org/jira/browse/HIVE-4593
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.10.0
>            Reporter: Eugene Koifman
>            Assignee: Navis
>         Attachments: HIVE-4593.D10965.1.patch
>
>
> All of these errorCode values are associated with more than one message.
> 10043
> 10227
> 10228
> 10229
> 10230
> 10231
> This is not right.
> This affects ErrorMsg.getErrorMsg(int errorCode) as well as Templeton logic.
> Should probably add a JUnit test to check this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to