----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11029/#review20380 -----------------------------------------------------------
Thejas, Thanks for all the work you've been doing! I was wondering, could you be able to place the JIRA description in the RB summary? It helps correlate RB items with JIRAs in the mind. A small description of the change is often helpful as well? Often times there are many ways to fix something, it's often useful to know why a particular solution was chosen. Cheers and thanks again! ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryViewer.java <https://reviews.apache.org/r/11029/#comment41959> This is bad... I know it's not related to your change but can we fix this? - Brock Noland On May 9, 2013, 4:29 p.m., Thejas Nair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11029/ > ----------------------------------------------------------- > > (Updated May 9, 2013, 4:29 p.m.) > > > Review request for hive. > > > Description > ------- > > HIVE-4513 > > > This addresses bug HIVE-4513. > https://issues.apache.org/jira/browse/HIVE-4513 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1672453 > conf/hive-default.xml.template 3a7d1dc > data/conf/hive-site.xml 544ba35 > ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java e1c1ae3 > ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryImpl.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryProxyHandler.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryUtil.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryViewer.java > fdd56db > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 3d43451 > ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java a783303 > > Diff: https://reviews.apache.org/r/11029/diff/ > > > Testing > ------- > > > Thanks, > > Thejas Nair > >
