[ 
https://issues.apache.org/jira/browse/HIVE-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640005#comment-13640005
 ] 

Thejas M Nair commented on HIVE-4398:
-------------------------------------

[~vaidya] Can you please upload this patch (or an updated patch) to reviewboard 
(https://reviews.apache.org) or phabricator ?
Review comments -
- operationToSession in OperationManager seems to be unnecessary. 
Operation.getParentSession() can be used to find the HiveSession associated 
with the operator.
- I also think it would be better to store the list of Operations to be closed 
in the HiveSession itself (as a HashSet), instead of doing that in the 
OperationManager . 
                
> HS2 Resource leak: operation handles not cleaned when originating session is 
> closed
> -----------------------------------------------------------------------------------
>
>                 Key: HIVE-4398
>                 URL: https://issues.apache.org/jira/browse/HIVE-4398
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2
>    Affects Versions: 0.10.0
>            Reporter: Ashish Vaidya
>             Fix For: 0.11.0
>
>         Attachments: HIVE-4398.branch-0.11.patch
>
>
> In HS2 closing of sessions doesn't lead to closing of all the operation 
> handles that the session had opened. This JIRA is meant to address this issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to