[ 
https://issues.apache.org/jira/browse/HIVE-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637305#comment-13637305
 ] 

Phabricator commented on HIVE-4333:
-----------------------------------

ashutoshc has requested changes to the revision "HIVE-4333 [jira] most 
windowing tests fail on hadoop 2".

  Few comments. Also, you need to apply HIVE-4369 to test on hadoop 2

INLINE COMMENTS
  ql/src/test/queries/clientpositive/ptf.q:200 Is it one of those which are 
deferring in precision after 2 decimal places. Shall we use round (sum 
(p_size),1) for these ?
  ql/src/test/queries/clientpositive/leadlag.q:76 It will be better to rewrite 
this query as
  select p_name, p_retailprice,
  lead(p_retailprice) over() as l1 ,
  lag(p_retailprice)  over() as l2
  from part
  where p_retailprice = 1173.15;

  we want to test over() here, so adding order by effectively defeats the 
purpose.
  I tested this query and it passes with 23 as well.
  ql/src/test/queries/clientpositive/windowing.q:278 Shall we use round 
(sum(p_size), 1) here ?

REVISION DETAIL
  https://reviews.facebook.net/D10389

BRANCH
  HIVE-4333

ARCANIST PROJECT
  hive

To: JIRA, ashutoshc, hbutani

                
> most windowing tests fail on hadoop 2
> -------------------------------------
>
>                 Key: HIVE-4333
>                 URL: https://issues.apache.org/jira/browse/HIVE-4333
>             Project: Hive
>          Issue Type: Bug
>          Components: PTF-Windowing
>    Affects Versions: 0.11.0
>            Reporter: Gunther Hagleitner
>            Assignee: Harish Butani
>         Attachments: HIVE-4333.1.patch.txt, HIVE-4333.D10389.1.patch
>
>
> Problem is different order of results on hadoop 2

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to