[ 
https://issues.apache.org/jira/browse/HIVE-4294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628811#comment-13628811
 ] 

Phabricator commented on HIVE-4294:
-----------------------------------

njain has commented on the revision "HIVE-4294 [jira] Single sourced multi 
query cannot handle lateral view".

  Looks good


  minor comments:

  Operator and Operator<?> should be replaced by:
  Operator<? extends OperatorDesc>

  mostly looks good

INLINE COMMENTS
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:6975 ? 
extends Serializable
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:6996 
Operator ---> Operator<? extends Serializable>
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:7236 ? -->  
? extends OperatorDesc
  ql/src/test/queries/clientpositive/multi_insert_lateral_view.q:49 This test 
is awesome, can you add a comment about the common distinct optimization for 
this plan.
  It takes some time to get it from the query plan.
  Some simple comments would really help

REVISION DETAIL
  https://reviews.facebook.net/D10161

To: JIRA, navis
Cc: njain

                
> Single sourced multi query cannot handle lateral view
> -----------------------------------------------------
>
>                 Key: HIVE-4294
>                 URL: https://issues.apache.org/jira/browse/HIVE-4294
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Minor
>         Attachments: HIVE-4294.D10161.1.patch
>
>
> For example,
> {noformat}
> hive> explain from src 
>     > select key, C lateral view explode(array(key, value)) A as C;
> FAILED: ParseException line 3:22 missing EOF at 'view' near 'lateral'
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to