[ https://issues.apache.org/jira/browse/HIVE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624513#comment-13624513 ]
Phabricator commented on HIVE-4302: ----------------------------------- ashutoshc has requested changes to the revision "HIVE-4302 [jira] Fix how RowSchema and RowResolver are set on ReduceSinkOp that precedes PTFOp". Also, it will be good to have a test-case I had in HIVE-2340 hive> create table t1 (a1 int, b1 string); hive> create table t2 (a1 int, b1 string); hive> from (select sum(i) over (), s from over10k) tt insert overwrite table t1 select * insert overwrite table t2 select * ; hive> select * from t1 limit 3; hive> select * from t2 limit 3; INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:10543 Now that we have gotten rid of having support with ptf operator, is this now redundant? ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:10552 If above statement is correct, than we need to update this comment as well. ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:10554 And remove this if block. REVISION DETAIL https://reviews.facebook.net/D10005 BRANCH HIVE-4302 ARCANIST PROJECT hive To: JIRA, ashutoshc, hbutani > Fix how RowSchema and RowResolver are set on ReduceSinkOp that precedes PTFOp > ----------------------------------------------------------------------------- > > Key: HIVE-4302 > URL: https://issues.apache.org/jira/browse/HIVE-4302 > Project: Hive > Issue Type: Bug > Components: PTF-Windowing > Reporter: Harish Butani > Assignee: Harish Butani > Attachments: HIVE-4302.D10005.1.patch > > > Currently the RowSchema and RowResolver for the ReduceSinkOp just point to > the 'input' Op's structures. This causes issues when input Op's structures > are changed during Optimization. See Jira 2340 of a problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira