[
https://issues.apache.org/jira/browse/HIVE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624249#comment-13624249
]
Travis Crawford commented on HIVE-4304:
---------------------------------------
Hey [~hagleitn] - ha, I just finished doing roughly the same thing. My branch
is [https://github.com/traviscrawford/hive/tree/HIVE-4304_rm_builtins_pdk].
Using git grep I found a number of other references too, in particular as ivy
dependencies, eclipse classpath entries, and in start scripts.
Can you give my branch a quick look? If you think it looks good I can kick off
tests and post the diff for review.
> Remove unused builtins and pdk submodules
> -----------------------------------------
>
> Key: HIVE-4304
> URL: https://issues.apache.org/jira/browse/HIVE-4304
> Project: Hive
> Issue Type: Improvement
> Reporter: Travis Crawford
> Assignee: Travis Crawford
> Attachments: HIVE-4304.1.patch
>
>
> Moving from email. The
> [builtins|http://svn.apache.org/repos/asf/hive/trunk/builtins/] and
> [pdk|http://svn.apache.org/repos/asf/hive/trunk/pdk/] submodules are not
> believed to be in use and should be removed. The main benefits are
> simplification and maintainability of the Hive code base.
> Forwarded conversation
> Subject: builtins submodule - is it still needed?
> ------------------------
> From: Travis Crawford <[email protected]>
> Date: Thu, Apr 4, 2013 at 2:01 PM
> To: [email protected], [email protected]
> Hey hive gurus -
> Is the "builtins" hive submodule in use? The submodule was added in
> HIVE-2523 as a location for builtin-UDFs, but it appears to not have
> taken off. Any objections to removing it?
> DETAILS
> For HIVE-4278 I'm making some build changes for the HCatalog
> integration. The "builtins" submodule causes issues because it delays
> building until the packaging phase - so HCatalog can't depend on
> builtins, which it does transitively.
> While investigating a path forward I discovered the "builtins"
> submodule contains very little code, and likely could either go away
> entirely or merge into "ql", simplifying things both for users and
> developers.
> Thoughts? Can anyone with context help me understand "builtins", both
> in general and around its non-standard build? For your trouble I'll
> either make the submodule go away/merge into another submodule, or
> update the docs with what we learn.
> Thanks!
> Travis
> ----------
> From: Ashutosh Chauhan <[email protected]>
> Date: Fri, Apr 5, 2013 at 3:10 PM
> To: [email protected]
> Cc: "[email protected]" <[email protected]>
> I haven't used it myself anytime till now. Neither have met anyone who used
> it or plan to use it.
> Ashutosh
> On Thu, Apr 4, 2013 at 2:01 PM, Travis Crawford
> <[email protected]>wrote:
> ----------
> From: Gunther Hagleitner <[email protected]>
> Date: Fri, Apr 5, 2013 at 3:11 PM
> To: [email protected]
> Cc: [email protected]
> +1
> I would actually go a step further and propose to remove both PDK and
> builtins. I've went through the code for both and here is what I found:
> Builtins:
> - BuiltInUtils.java: Empty file
> - UDAFUnionMap: Merges maps. Doesn't seem to be useful by itself, but was
> intended as a building block for PDK
> PDK:
> - some helper build.xml/test setup + teardown scripts
> - Classes/annotations to help run unit tests
> - rot13 as an example
> From what I can tell it's a fair assessment that it hasn't taken off, last
> commits to it seem to have happened more than 1.5 years ago.
> Thanks,
> Gunther.
> On Thu, Apr 4, 2013 at 2:01 PM, Travis Crawford
> <[email protected]>wrote:
> ----------
> From: Owen O'Malley <[email protected]>
> Date: Fri, Apr 5, 2013 at 4:45 PM
> To: [email protected]
> +1 to removing them.
> We have a Rot13 example in
> ql/src/test/org/apache/hadoop/hive/ql/io/udf/Rot13{In,Out}putFormat.java
> anyways. *smile*
> -- Owen
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
