[ https://issues.apache.org/jira/browse/HIVE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605646#comment-13605646 ]
Alan Gates commented on HIVE-4197: ---------------------------------- Harish, This is really helpful, thanks. I have a few questions: Section 2.1, what is a Source Window Spec? Section 3, I can't see any way in an MR framework to guarantee order stability without adding an order clause. I suppose we could add an implicit one that doesn't change the window frame, but that seems expensive. I'd say just note that we don't guarantee a stable order here and if users want a stable order they should put in an order by. Section 3.1.2 The addition of +1 to all of the following specifications seems wrong. If window definition says BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW I believe the spec stipulates that it will end at the current row, not one past the current row. Section 3.1.3 Where are we at on RANGE support? I'm wondering if it would be better to focus on stabilizing ROWS support for now and adding RANGE support later. > Bring windowing support inline with SQL Standard > ------------------------------------------------ > > Key: HIVE-4197 > URL: https://issues.apache.org/jira/browse/HIVE-4197 > Project: Hive > Issue Type: Bug > Components: PTF-Windowing > Reporter: Harish Butani > Attachments: WindowingSpecification.pdf > > > The current behavior defers from the Standard in several significant places. > Please review attached doc; there are still a few open issues. Once we agree > on the behavior, can proceed with fixing the implementation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira