[ 
https://issues.apache.org/jira/browse/HIVE-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604118#comment-13604118
 ] 

Gunther Hagleitner commented on HIVE-4187:
------------------------------------------

I saw your comments on HIVE-4148 as well. Yes, I see your point, but I do think 
that dependencies specified in fewer places leads to something that's easier to 
maintain. 

My thinking was:

- I believe the modules aren't/can't be built in isolation anyways, so why 
duplicate all the deps 
- Nothing seems to enforce that each module has a complete set of deps, so it's 
best effort at best
- I see duplicated "hacks" and "broken pom file" stuff in the ivy scripts that 
I'd rather have in one place. 

The build speed is secondary, but I also don't understand how your system is 
faster with more dependencies to resolve than with fewer.

I am not married to HIVE-4148 either, although if the decision is to enforce 
that each module specifies all it deps directly, I'd like to go over the patch 
again and see what can and can't be removed rather than just reverting.

Having said that, I was simply jumping on this one first, because a broken 
build seems more urgent and I want to fix that right away. However, in order to 
do that I would like to know how your build is broken. Ivy should pick up the 
right version, the build machine doesn't have the problem and I can't reproduce 
it. Do you have any pointers?
                
> QL build-grammar target fails after HIVE-4148
> ---------------------------------------------
>
>                 Key: HIVE-4187
>                 URL: https://issues.apache.org/jira/browse/HIVE-4187
>             Project: Hive
>          Issue Type: Bug
>          Components: Build Infrastructure
>            Reporter: Carl Steinbach
>            Assignee: Gunther Hagleitner
>            Priority: Critical
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to