[
https://issues.apache.org/jira/browse/HIVE-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13602037#comment-13602037
]
Phabricator commented on HIVE-4041:
-----------------------------------
hbutani has commented on the revision "HIVE-4041 [jira] Support multiple
partitionings in a single Query".
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java:212
We need to maintain the order of the original columns. This is because at
runtime we reconstruct the OIs using the serde props map which has the column
names and types.
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkDeDuplication.java:415
because ExprNodeConstantDesc returns a null for the getCols() call.
for the over() case we add a Constant expression to the Partition list
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkDeDuplication.java:425
same reason as above
ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java:482 What we
are doing today is adding the partition columns as a prefix to the order
expressions. Functionally it should not matter; but it is not needed and
probably has a performance impact. I need to test that removal.
Was planning to do this for Jira 4109. Didn't want to change this behavior in
this Jira. But with the refactoring it is quite easy to remove the prefixing
code.
REVISION DETAIL
https://reviews.facebook.net/D9381
To: JIRA, ashutoshc, hbutani
> Support multiple partitionings in a single Query
> ------------------------------------------------
>
> Key: HIVE-4041
> URL: https://issues.apache.org/jira/browse/HIVE-4041
> Project: Hive
> Issue Type: Bug
> Components: PTF-Windowing
> Reporter: Harish Butani
> Assignee: Harish Butani
> Attachments: HIVE-4041.D9381.1.patch, WindowingComponentization.pdf
>
>
> Currently we disallow queries if the partition specifications of all Wdw fns
> are not the same. We can relax this by generating multiple PTFOps based on
> the unique partitionings in a Query. For partitionings that only differ in
> sort, we can introduce a sort step in between PTFOps, which can happen in the
> same Reduce task.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
