[ 
https://issues.apache.org/jira/browse/HIVE-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13596114#comment-13596114
 ] 

Phabricator commented on HIVE-4125:
-----------------------------------

kevinwilfong has commented on the revision "HIVE-4125 [jira] Expose metastore 
JMX metrics".

INLINE COMMENTS
  common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java:197-202 
Could you just use this method instead of implementing it again inside of 
MetricsScope?
  common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java:71 Why not 
expose this too for consistency?

REVISION DETAIL
  https://reviews.facebook.net/D9123

To: kevinwilfong, sxyuan
Cc: JIRA

                
> Expose metastore JMX metrics
> ----------------------------
>
>                 Key: HIVE-4125
>                 URL: https://issues.apache.org/jira/browse/HIVE-4125
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 0.11.0
>            Reporter: Samuel Yuan
>            Assignee: Samuel Yuan
>            Priority: Trivial
>         Attachments: HIVE-4125.HIVE-4125.HIVE-4125.D9123.1.patch
>
>
> Add a safe way to access the metrics stored for each MetricsScope, so that 
> they can be used outside of JMX.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to