[ https://issues.apache.org/jira/browse/HIVE-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated HIVE-4073: ------------------------------- Attachment: HIVE-4073-1.patch [~ashutoshc] Attached patch seems to work fine but ptf_negative_AggrFuncsWithNoGBYNoPartDef fails ,due to this change, which needs to be resolved somehow. Quick question about which direction I should take in implementation: TL;DR: Should the query "select sum(p_retailprice) as s1 from part;" throw a SemanticException? I assumed yes as postgres does not allow it and there is a test for it ptf_negative_AggrFuncsWithNoGBYNoPartDef. However, it looks like the behavior of moving aggregates with no group by op to window ops was specifically allowed based on the two comments below: https://github.com/apache/hive/blob/ptf-windowing/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java#L858 https://github.com/apache/hive/blob/ptf-windowing/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java#L10561 > Make partition by optional in over clause > ----------------------------------------- > > Key: HIVE-4073 > URL: https://issues.apache.org/jira/browse/HIVE-4073 > Project: Hive > Issue Type: Bug > Components: PTF-Windowing > Reporter: Ashutosh Chauhan > Assignee: Brock Noland > Attachments: HIVE-4073-0.patch, HIVE-4073-1.patch > > > select s, sum( i ) over() from tt; should work. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira