[ https://issues.apache.org/jira/browse/HIVE-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-4080: ------------------------------ Attachment: HIVE-4080.D8961.1.patch hbutani requested code review of "HIVE-4080 [jira] Add Lead & Lag UDAFs". Reviewers: JIRA add Lead and Lag UDAFs Currently we support Lead/Lag as navigation UDFs usable with Windowing. To be standard compliant we need to support Lead & Lag UDAFs. Will continue to support Lead/Lag UDFs as arguments to UDAFs when Windowing is in play. Currently allow Lead/Lag expressions to appear in SelectLists even when they are not arguments to UDAFs. Support for this feature will probably be removed. Causes ambiguities when Query contains different partition clauses. Will provide more details with associated Jira to remove this feature. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D8961 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFLag.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFLead.java ql/src/test/queries/clientpositive/leadlag_queries.q ql/src/test/results/clientpositive/leadlag_queries.q.out MANAGE HERALD RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/21705/ To: JIRA, hbutani > Add Lead & Lag UDAFs > -------------------- > > Key: HIVE-4080 > URL: https://issues.apache.org/jira/browse/HIVE-4080 > Project: Hive > Issue Type: Bug > Components: PTF-Windowing > Reporter: Harish Butani > Assignee: Harish Butani > Attachments: HIVE-4080.1.patch.txt, HIVE-4080.D8961.1.patch > > > Currently we support Lead/Lag as navigation UDFs usable with Windowing. > To be standard compliant we need to support Lead & Lag UDAFs. > Will continue to support Lead/Lag UDFs as arguments to UDAFs when Windowing > is in play. > Currently allow Lead/Lag expressions to appear in SelectLists even when they > are not arguments to UDAFs. Support for this feature will probably be > removed. Causes ambiguities when Query contains different partition clauses. > Will provide more details with associated Jira to remove this feature. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira