[ 
https://issues.apache.org/jira/browse/HIVE-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-4016:
------------------------------

    Attachment: HIVE-4016.D8547.2.patch

navis updated the revision "HIVE-4016 [jira] Remove init(fname) from 
TestParse.vm for each test".

  Addressed commnets (removed dummy incrementors and updated result plans)

Reviewers: ashutoshc, JIRA

REVISION DETAIL
  https://reviews.facebook.net/D8547

CHANGE SINCE LAST DIFF
  https://reviews.facebook.net/D8547?vs=27657&id=28263#toc

AFFECTED FILES
  ql/src/test/results/compiler/plan/case_sensitivity.q.xml
  ql/src/test/results/compiler/plan/cast1.q.xml
  ql/src/test/results/compiler/plan/groupby1.q.xml
  ql/src/test/results/compiler/plan/groupby2.q.xml
  ql/src/test/results/compiler/plan/groupby3.q.xml
  ql/src/test/results/compiler/plan/groupby4.q.xml
  ql/src/test/results/compiler/plan/groupby5.q.xml
  ql/src/test/results/compiler/plan/groupby6.q.xml
  ql/src/test/results/compiler/plan/input1.q.xml
  ql/src/test/results/compiler/plan/input2.q.xml
  ql/src/test/results/compiler/plan/input20.q.xml
  ql/src/test/results/compiler/plan/input3.q.xml
  ql/src/test/results/compiler/plan/input4.q.xml
  ql/src/test/results/compiler/plan/input5.q.xml
  ql/src/test/results/compiler/plan/input6.q.xml
  ql/src/test/results/compiler/plan/input7.q.xml
  ql/src/test/results/compiler/plan/input8.q.xml
  ql/src/test/results/compiler/plan/input9.q.xml
  ql/src/test/results/compiler/plan/input_part1.q.xml
  ql/src/test/results/compiler/plan/input_testsequencefile.q.xml
  ql/src/test/results/compiler/plan/input_testxpath.q.xml
  ql/src/test/results/compiler/plan/input_testxpath2.q.xml
  ql/src/test/results/compiler/plan/join1.q.xml
  ql/src/test/results/compiler/plan/join2.q.xml
  ql/src/test/results/compiler/plan/join3.q.xml
  ql/src/test/results/compiler/plan/join4.q.xml
  ql/src/test/results/compiler/plan/join5.q.xml
  ql/src/test/results/compiler/plan/join6.q.xml
  ql/src/test/results/compiler/plan/join7.q.xml
  ql/src/test/results/compiler/plan/join8.q.xml
  ql/src/test/results/compiler/plan/sample1.q.xml
  ql/src/test/results/compiler/plan/sample2.q.xml
  ql/src/test/results/compiler/plan/sample3.q.xml
  ql/src/test/results/compiler/plan/sample4.q.xml
  ql/src/test/results/compiler/plan/sample5.q.xml
  ql/src/test/results/compiler/plan/sample6.q.xml
  ql/src/test/results/compiler/plan/sample7.q.xml
  ql/src/test/results/compiler/plan/subq.q.xml
  ql/src/test/results/compiler/plan/udf1.q.xml
  ql/src/test/results/compiler/plan/udf4.q.xml
  ql/src/test/results/compiler/plan/udf6.q.xml
  ql/src/test/results/compiler/plan/udf_case.q.xml
  ql/src/test/results/compiler/plan/udf_when.q.xml
  ql/src/test/results/compiler/plan/union.q.xml
  ql/src/test/templates/TestParse.vm

To: JIRA, ashutoshc, navis

                
> Remove init(fname) from TestParse.vm for each test
> --------------------------------------------------
>
>                 Key: HIVE-4016
>                 URL: https://issues.apache.org/jira/browse/HIVE-4016
>             Project: Hive
>          Issue Type: Improvement
>          Components: Testing Infrastructure
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-4016.D8547.1.patch, HIVE-4016.D8547.2.patch
>
>
> TestParse does not change any of configuration or data, which means calling 
> init() method before each test is not necessary. After removing it, test time 
> reduced to 260sec to 16sec.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to