[ https://issues.apache.org/jira/browse/HIVE-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13581395#comment-13581395 ]
Jarek Jarcec Cecho commented on HIVE-4007: ------------------------------------------ Hi Namit, thank you very much for working on this. I've took a look on the patch and I do have one high level question. It seems to me that we're just adding {{AbstractSerDe}} that all {{SerDe}} implementations will extend in the future to allow the easy extension for future functionality. But it also seems that we're keeping the old {{SerDe}} interface implementation. Since no {{SerDe}} should implement that directly, it seems to me that it's unnecessary piece of code. I can imagine that it would be great to keep it around for a release or two to provide backward compatibility and allow Hive users to migrate they codebase without immediately breaking the environment. I would suggest to mark this interface as {{@Deprecated}} in case that this is the intent. Jarcec > Create abstract classes for serializer and deserializer > ------------------------------------------------------- > > Key: HIVE-4007 > URL: https://issues.apache.org/jira/browse/HIVE-4007 > Project: Hive > Issue Type: Improvement > Components: Serializers/Deserializers > Reporter: Namit Jain > Assignee: Namit Jain > Attachments: hive.4007.1.patch, hive.4007.2.patch > > > Currently, it is very difficult to change the Serializer/Deserializer > interface, since all the SerDes directly implement the interface. > Instead, we should have abstract classes for implementing these interfaces. > In case of a interface change, only the abstract class and the relevant > serde needs to change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira