[
https://issues.apache.org/jira/browse/HIVE-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576319#comment-13576319
]
Phabricator commented on HIVE-701:
----------------------------------
kevinwilfong has commented on the revision "HIVE-701 [jira] Make keywords
non-reserved".
Could you highlight what changes you made to the grammar files (besides
splitting them up)? It's hard to tell given that the code is all in new files.
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g:461 If URL
was not already in the grammar, could you hold off on adding it until you have
a use for it?
ql/src/java/org/apache/hadoop/hive/ql/parse/FromClauseParser.g:17 I don't see
this getting imported anywhere, how is it getting included?
Alternatively, what am I missing?
REVISION DETAIL
https://reviews.facebook.net/D8397
To: kevinwilfong, JIRA, sxyuan
Cc: njain
> lots of reserved keywords in hive
> ---------------------------------
>
> Key: HIVE-701
> URL: https://issues.apache.org/jira/browse/HIVE-701
> Project: Hive
> Issue Type: New Feature
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Samuel Yuan
> Attachments: HIVE-701.1.patch.txt, HIVE-701.2.patch.txt,
> HIVE-701.D8397.1.patch, HIVE-701.HIVE-701.D8397.2.patch
>
>
> There is a problem if we want to use some reserved keywords:
> for example, creating a function of name left/right ? left/right is already a
> reserved keyword.
> The other way around should also be possible - if we want to add a 'show
> tables status' and some applications already use status as a column name,
> they should not break
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
