[ 
https://issues.apache.org/jira/browse/HIVE-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574249#comment-13574249
 ] 

Mark Grover commented on HIVE-3995:
-----------------------------------

+1 (non-committer)

Thanks Jarcec! I left a comment (no action required from your side) on 
Reviewboard that "false" seems to be the right value to put for existing rows. 
Perhaps, [~gangtimliu] or [~namitjain], who were involved with HIVE-3649 can 
confirm.

I like the new approach of adding the new column as Nullable, updating the 
existing null values and then setting the column to not-null. The only other 
approach I can think of is to use a default value (of false) but that seems 
more risky in the long run.
                
> PostgreSQL upgrade scripts are not valid
> ----------------------------------------
>
>                 Key: HIVE-3995
>                 URL: https://issues.apache.org/jira/browse/HIVE-3995
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>            Reporter: Jarek Jarcec Cecho
>         Attachments: postgre_update_issue.patch, postgre_update_issue.patch
>
>
> I've noticed that scripts for upgrading metastore backed up on PostgreSQL are 
> not valid.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to