[ https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568466#comment-13568466 ]
Phabricator commented on HIVE-2340: ----------------------------------- navis has commented on the revision "HIVE-2340 [jira] optimize orderby followed by a groupby". INLINE COMMENTS common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:521 Yes, it is. There should be a better configuration if possible. ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkDeDuplication.java:787 Yes, should be 'fixed' as sorted state. I'll rename it. I think there should be a configuration preventing MAPJOINable JOIN from being merged with next RS. But seemed hard to know if it's mapjoinable. Any idea? ql/src/java/org/apache/hadoop/hive/ql/ppd/PredicateTransitivePropagate.java:136 Yes, typos. I'll remove this from patch. ql/src/test/queries/clientpositive/reduce_deduplicate.q:7 ok. REVISION DETAIL https://reviews.facebook.net/D1209 To: JIRA, navis Cc: hagleitn > optimize orderby followed by a groupby > -------------------------------------- > > Key: HIVE-2340 > URL: https://issues.apache.org/jira/browse/HIVE-2340 > Project: Hive > Issue Type: Sub-task > Components: Query Processor > Reporter: Navis > Assignee: Navis > Priority: Minor > Labels: perfomance > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2340.D1209.1.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2340.D1209.2.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2340.D1209.3.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2340.D1209.4.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2340.D1209.5.patch, HIVE-2340.1.patch.txt, > HIVE-2340.D1209.6.patch, HIVE-2340.D1209.7.patch, HIVE-2340.D1209.8.patch, > HIVE-2340.D1209.9.patch, testclidriver.txt > > > Before implementing optimizer for JOIN-GBY, try to implement RS-GBY > optimizer(cluster-by following group-by). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira