[
https://issues.apache.org/jira/browse/HIVE-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561483#comment-13561483
]
Mark Grover commented on HIVE-3918:
-----------------------------------
You can see the files that still have Windows style line endings by running
{code}
grep -r $'\r' * -l | uniq | sort
{code}
The result will be a superset of the files this patch affects. The files that
are returned as a result of the above grep but are not touched by this patch
are those that can legitimately contain ^M.
Here is a list of them, just for reference, we shouldn't change anything about
them:
{code}
> data/files/archive_corrupt.rc
> data/files/complex.seq
> data/files/doctors.avro
> data/files/escapetest.txt
> data/files/kv1_broken.seq
> data/files/kv1.seq
> data/files/lt100.txt.deflate
> data/files/smbbucket_1.rc
> data/files/smbbucket_2.rc
> data/files/smbbucket_3.rc
> data/files/TestSerDe.jar
> docs/images/hive-logo.jpg
> hwi/web/img/glyphicons-halflings.png
> hwi/web/img/glyphicons-halflings-white.png
> testlibs/ant-contrib-1.0b3.jar
{code}
> Normalize more CRLF line endings
> --------------------------------
>
> Key: HIVE-3918
> URL: https://issues.apache.org/jira/browse/HIVE-3918
> Project: Hive
> Issue Type: Bug
> Reporter: Mark Grover
> Assignee: Mark Grover
> Attachments: HIVE-3918.1.patch
>
>
> While I tried to fix files that had incompatible line endings in HIVE-3858, I
> missed some more files. It was most likely because HIVE-3858 was tested by me
> on Mac OS X but when I started using the github repository on a ubuntu box, I
> saw there are some more files in the Hive repo that have incorrect line
> endings. These files get added to the index automatically when a change is
> made to the local git repo. Once these cosmetic changes get committed, we
> would have gotten rid of all windows/old Mac OS style line endings in our
> Hive repository.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
