[ 
https://issues.apache.org/jira/browse/HIVE-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558452#comment-13558452
 ] 

Phabricator commented on HIVE-3628:
-----------------------------------

navis has commented on the revision "HIVE-3628 [jira] Provide a way to use 
counters in Hive through UDF".

INLINE COMMENTS
  
ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java:148
 Annotations are providing some contextual traits which cannot be expressed in 
UDF implementation by code. So it should be described by those.

  But for this case, it's clear what is needed if user overrided init/close 
method. Would there be a possible case not to call those by annotation? (for 
some test cases maybe?)

  I'll think that again.
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapredContext.java:39 it's not. I 
think I should do some refactoring.

REVISION DETAIL
  https://reviews.facebook.net/D8007

To: JIRA, navis
Cc: njain

                
> Provide a way to use counters in Hive through UDF
> -------------------------------------------------
>
>                 Key: HIVE-3628
>                 URL: https://issues.apache.org/jira/browse/HIVE-3628
>             Project: Hive
>          Issue Type: Improvement
>          Components: UDF
>            Reporter: Viji
>            Assignee: Navis
>            Priority: Minor
>         Attachments: HIVE-3628.D8007.1.patch, HIVE-3628.D8007.2.patch, 
> HIVE-3628.D8007.3.patch
>
>
> Currently it is not possible to generate counters through UDF. We should 
> support this. 
> Pig currently allows this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to