[ 
https://issues.apache.org/jira/browse/HIVE-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544809#comment-13544809
 ] 

Ashutosh Chauhan commented on HIVE-3789:
----------------------------------------

I get the need of adding resolvePath(), but I didn't get the need of modifying 
checkPath(). I don't see that current impl as being necessarily incorrect. I 
guess you are thinking that passed in path must be checked for pfile:// scheme 
if its non-relative and all other edge cases. But I am not sure we should make 
these checks.  super.checkPath(swizzleParamPath(path)) will replace real scheme 
and authority in the path and then checks are made against the real FS in 
super(). I think that is sufficient. If you revert the changes in checkPath() 
do test cases fail? If they don't, I will suggest to revert changes in 
checkPath(). 
                
> Patch HIVE-3648 causing the majority of unit tests to fail on branch 0.9
> ------------------------------------------------------------------------
>
>                 Key: HIVE-3789
>                 URL: https://issues.apache.org/jira/browse/HIVE-3789
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore, Tests
>    Affects Versions: 0.9.0, 0.10.0
>         Environment: Hadooop 0.23.5, JDK 1.6.0_31
>            Reporter: Chris Drome
>            Assignee: Arup Malakar
>         Attachments: HIVE-3789.branch-0.9_1.patch, HIVE-3789.trunk.1.patch
>
>
> Rolling back to before this patch shows that the unit tests are passing, 
> after the patch, the majority of the unit tests are failing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to