[
https://issues.apache.org/jira/browse/HIVE-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544227#comment-13544227
]
Gunther Hagleitner commented on HIVE-2693:
------------------------------------------
I thought I had added a response on the ambiguous UDF issue on the review, but
it seems I never submitted that. It's there now.
I think it would be rather cumbersome to remove that piece from the patch. We
would have to remove all the conversion code from the file (including any
implicit conversion of numbers to decimal) and then rewrite all the tests to
work around this. Just to re-introduce this in a new jira and change the tests
back to what they were.
It seems Mark you have an idea of re-writing this piece altogether using
different cost for conversions. I think that's more intrusive (the current code
just adds a case for multiple choices) and could be handled in another jira.
> Add DECIMAL data type
> ---------------------
>
> Key: HIVE-2693
> URL: https://issues.apache.org/jira/browse/HIVE-2693
> Project: Hive
> Issue Type: New Feature
> Components: Query Processor, Types
> Affects Versions: 0.10.0
> Reporter: Carl Steinbach
> Assignee: Prasad Mujumdar
> Attachments: 2693_7.patch, 2693_8.patch, 2693_fix_all_tests1.patch,
> HIVE-2693-10.patch, HIVE-2693-11.patch, HIVE-2693-12-SortableSerDe.patch,
> HIVE-2693-13.patch, HIVE-2693-14.patch, HIVE-2693-15.patch,
> HIVE-2693-16.patch, HIVE-2693-17.patch, HIVE-2693-1.patch.txt,
> HIVE-2693-all.patch, HIVE-2693.D7683.1.patch, HIVE-2693-fix.patch,
> HIVE-2693.patch, HIVE-2693-take3.patch, HIVE-2693-take4.patch
>
>
> Add support for the DECIMAL data type. HIVE-2272 (TIMESTAMP) provides a nice
> template for how to do this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
