----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5685/#review15002 -----------------------------------------------------------
It doesn't look like I can build this until configure.ac and Makefile.am scripts are added to the top-level odbc/ directory. Please add these files and verify that it's possible to build everything by running the following commands from odbc/ configure && make clean && make && make install Thanks odbc/src/cpp/Makefile.am <https://reviews.apache.org/r/5685/#comment32341> Please change this to $THRIFT_HOME/share/fb303/if/fb303.thrift and remove fb303.thrift from the odbc directory. odbc/src/cpp/if/fb303.thrift <https://reviews.apache.org/r/5685/#comment32342> Please remove this file. odbc/src/cpp/if/hive_metastore.thrift <https://reviews.apache.org/r/5685/#comment32343> Please remove this file. odbc/src/cpp/if/hive_service.thrift <https://reviews.apache.org/r/5685/#comment32344> Please remove this file. odbc/src/cpp/if/queryplan.thrift <https://reviews.apache.org/r/5685/#comment32345> Please remove this file. - Carl Steinbach On Oct. 8, 2012, 5:10 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5685/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2012, 5:10 a.m.) > > > Review request for hive and Carl Steinbach. > > > Description > ------- > > Enhanced ODBC driver with limited ODBC3 compliance. This ticket HIVE-3213 > covers the source code, the build changes are tracked by HIVE-3212 > > > This addresses bug HIVE-3213. > https://issues.apache.org/jira/browse/HIVE-3213 > > > Diffs > ----- > > odbc/src/cpp/HiveConnection.h 3b2e2b1 > odbc/src/cpp/HiveResultSet.h 25eabc4 > odbc/src/cpp/HiveResultSet.cpp d3d375e > odbc/src/cpp/HiveRowSet.h ca6e6af > odbc/src/cpp/HiveRowSet.cpp 3de6124 > odbc/src/cpp/Makefile.am PRE-CREATION > odbc/src/cpp/Makefile.in PRE-CREATION > odbc/src/cpp/hiveclient.h f1af670 > odbc/src/cpp/hiveclient.cpp 450eb0b > odbc/src/cpp/hiveclient.def PRE-CREATION > odbc/src/cpp/hiveclienthelper.h 5814a03 > odbc/src/cpp/hiveconstants.h 72f1049 > odbc/src/cpp/if/fb303.thrift PRE-CREATION > odbc/src/cpp/if/hive_metastore.thrift PRE-CREATION > odbc/src/cpp/if/hive_service.thrift PRE-CREATION > odbc/src/cpp/if/queryplan.thrift PRE-CREATION > odbc/src/cpp/thriftserverconstants.h fe4bac4 > odbc/src/driver/Makefile.am PRE-CREATION > odbc/src/driver/Makefile.in PRE-CREATION > odbc/src/driver/hiveodbc.h PRE-CREATION > odbc/src/driver/hiveodbc.c PRE-CREATION > odbc/src/driver/hiveodbc_win32_rc.h PRE-CREATION > odbc/src/driver/hiveodbc_win32_rc.rc PRE-CREATION > odbc/src/driver/libhiveodbc.def PRE-CREATION > odbc/src/test/Makefile.am PRE-CREATION > odbc/src/test/Makefile.in PRE-CREATION > odbc/src/test/hiveclienttest.c fbb4e24 > odbc/src/test/hiveodbctest.c PRE-CREATION > odbc/src/test/hivetest.h PRE-CREATION > > Diff: https://reviews.apache.org/r/5685/diff/ > > > Testing > ------- > > > Thanks, > > Prasad Mujumdar > >
