[ https://issues.apache.org/jira/browse/HIVE-3772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538354#comment-13538354 ]
Phabricator commented on HIVE-3772: ----------------------------------- zshao has requested changes to the revision "[jira] [HIVE-3772] Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by Reynold Xin)". Please take this opportunity to fix all static variables in this file. By the way, a better way to fix is to use ThreadLocal. That's more effiicient because then we don't need to call new in these low-level functions. INLINE COMMENTS serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java:126 Is this a problem for multi-threaded access as well? REVISION DETAIL https://reviews.facebook.net/D7155 BRANCH HIVE-3772-static-vLongBytes To: ashutoshc, njain, raghotham, JIRA, zshao, heyongqiang, nzhang, jsichi, pauly, amareshwarisr, cwsteinbach, mbautin > Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by > Reynold Xin) > ------------------------------------------------------------------------------------- > > Key: HIVE-3772 > URL: https://issues.apache.org/jira/browse/HIVE-3772 > Project: Hive > Issue Type: Bug > Reporter: Mikhail Bautin > Attachments: D7155.1.patch, HIVE-3772-2012-12-04.patch > > > Creating a JIRA for [~rxin]'s patch needed by the Shark project. > https://github.com/amplab/hive/commit/17e1c3dd2f6d8eca767115dc46d5a880aed8c765 > writeVLong should not use a static field due to concurrency concerns. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira