[ 
https://issues.apache.org/jira/browse/HIVE-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533646#comment-13533646
 ] 

Mark Grover commented on HIVE-2693:
-----------------------------------

I was playing around with this and noticed that group by on Decimal column 
doesn't work because BinarySortableSerDe doesn't support DECIMAL type. It's 
questionable if it would ever support it since BigDecimal is arbitrarily long 
and BinarySortableSerDe dictates data to be serialized so that the value can be 
compared byte by byte with the same order. That would have been ok but it seems 
like {{getReduceKeyTableDesc}} in {{PlanUtils.java}} is hardcoded to use 
BinarySortableSerDe. I will have to poke around some more to see how Group By 
can be made to work with Decimal type (backed by BigDecimal).

In any case, the last patch didn't apply cleanly on trunk, so I fixed some 
merge conflicts and am attaching a new patch (#11) which is a refresh of patch 
10 that applies cleanly on trunk as of today.
                
> Add DECIMAL data type
> ---------------------
>
>                 Key: HIVE-2693
>                 URL: https://issues.apache.org/jira/browse/HIVE-2693
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor, Types
>    Affects Versions: 0.10.0
>            Reporter: Carl Steinbach
>            Assignee: Prasad Mujumdar
>         Attachments: 2693_7.patch, 2693_8.patch, 2693_fix_all_tests1.patch, 
> HIVE-2693-10.patch, HIVE-2693-11.patch, HIVE-2693-1.patch.txt, 
> HIVE-2693-all.patch, HIVE-2693-fix.patch, HIVE-2693.patch, 
> HIVE-2693-take3.patch, HIVE-2693-take4.patch
>
>
> Add support for the DECIMAL data type. HIVE-2272 (TIMESTAMP) provides a nice 
> template for how to do this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to