[
https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506334#comment-13506334
]
Phabricator commented on HIVE-3384:
-----------------------------------
ashutoshc has requested changes to the revision "[jira] [HIVE-3384] HIVE JDBC
module won't compile under JDK1.7 as new methods added in JDBC specification".
One more comment. Patch looks good otherwise.
INLINE COMMENTS
build-common.xml:440 Instead of hardcoding jvmarg I will suggest to define a
variable here $jvm.args and add it in build.properties with default value set
to -XX:-UseSplitVerifier that way folks can override this value if they want
(e.g. for non-Oracle jdks)
metastore/build.xml:106 Instead of hardcoding jvmarg I will suggest to define
a variable here $jvm.args and add it in build.properties with default value set
to -XX:-UseSplitVerifier that way folks can override this value if they want
(e.g. for non-Oracle jdks)
REVISION DETAIL
https://reviews.facebook.net/D6873
BRANCH
trunk-hive-3384-jdbc-compilation-on-jdk7
To: cdrome, weidongbian, JIRA, ashutoshc, mbautin
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC
> specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch,
> D6873.3.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in
> the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
