[ 
https://issues.apache.org/jira/browse/HIVE-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497767#comment-13497767
 ] 

Phabricator commented on HIVE-3431:
-----------------------------------

mgrover has commented on the revision "HIVE-3431 [jira] Resources on non-local 
file system should be downloaded to temporary directory sometimes".

  Navis, thanks for the changes. They look good to me, thanks!

  I think you raise an interesting question about magic words convention, one 
that's beyond the scope of this review. Would you please raise that question on 
the dev mailing list to see people have some opinion. Perhaps, someone could 
point out how other projects (e.g. hadoop) deal with it (I haven't checked 
myself yet). A couple of conventions I can think of would be:
  1. $temporary
  2. @temporary@
  3. @temporary

  Anyways, if you don't mind, post on the dev mailing list and we can take it 
on from there.

  Thanks again!

REVISION DETAIL
  https://reviews.facebook.net/D5199

To: JIRA, navis
Cc: mgrover

                
> Resources on non-local file system should be downloaded to temporary 
> directory sometimes
> ----------------------------------------------------------------------------------------
>
>                 Key: HIVE-3431
>                 URL: https://issues.apache.org/jira/browse/HIVE-3431
>             Project: Hive
>          Issue Type: Improvement
>          Components: Configuration
>    Affects Versions: 0.10.0
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-3431.1.patch.txt, HIVE-3431.D5199.2.patch
>
>
> "add resource <remote-uri>" command downloads the resource file to location 
> specified by conf "hive.downloaded.resources.dir" in local file system. But 
> when the command above is executed concurrently to hive-server for same file, 
> some client fails by VM crash, which is caused by overwritten file by other 
> requests.
> So there should be a configuration to provide per request location for add 
> resource command, something like "set 
> hiveconf:hive.downloaded.resources.dir=temporary"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to