----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7848/#review13318 -----------------------------------------------------------
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSleep.java <https://reviews.apache.org/r/7848/#comment28583> This might be confusing to some users. The method may call Thread.sleep but the UDF's argument is in seconds. So perhaps get rid "long millis" and mention that the UDF argument is in seconds - Mark Grover On Nov. 9, 2012, 11:10 p.m., Johnny Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7848/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2012, 11:10 p.m.) > > > Review request for hive. > > > Description > ------- > > To make testing issues like HIVE-3590 convenient, we can implement a UDF to > keep hive session alive for a given time. The patch introduce a new UDF > sleep() which does this without introducing any data/load to cluster. > > > This addresses bug HIVE-3666. > https://issues.apache.org/jira/browse/HIVE-3666 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java > 1405251 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSleep.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/7848/diff/ > > > Testing > ------- > > have tested it with Hive CLI and Hive Server session, and it can keep them > alive by the given seconds > > > Thanks, > > Johnny Zhang > >
