[
https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Drome updated HIVE-3384:
------------------------------
Attachment: HIVE-JDK7-JDBC.patch
A couple of comments, rather than returning null or doing nothing for a void
method, you should probably throw an exception. That way it is clear that the
method has not been implemented yet.
Other parts of the code are throwing SQLException("Method not supported"), so
you might want to do the same.
You missed some methods in HiveBaseResultSet.
I've included the patch that I'm using which contains these changes. You might
want to merge them together.
Also, I think you should submit your review request to phabricator instead of
apache review board.
https://cwiki.apache.org/confluence/display/Hive/PhabricatorCodeReview
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC
> specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in
> the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
