[ 
https://issues.apache.org/jira/browse/HIVE-3528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472023#comment-13472023
 ] 

Jakob Homan commented on HIVE-3528:
-----------------------------------

Looks good.  Added a couple comments to reviewboard.  Also, it would be great 
to add a .q test that the Avro Serde can handle null records (with a proper 
nullable Avro schema) from other formats from Hive.  Had meant to do that 
during the Apachification.  If you'd like to add that to this patch, that'd be 
great.  If not, I'll spin up a quick test after this gets committed.  
                
> Avro SerDe doesn't handle serializing Nullable types that require access to a 
> Schema
> ------------------------------------------------------------------------------------
>
>                 Key: HIVE-3528
>                 URL: https://issues.apache.org/jira/browse/HIVE-3528
>             Project: Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>            Reporter: Sean Busbey
>              Labels: avro
>         Attachments: HIVE-3528.1.patch.txt
>
>
> Deserialization properly handles hiding Nullable Avro types, including 
> complex types like record, map, array, etc. However, when Serialization 
> attempts to write out these types it erroneously makes use of the UNION 
> schema that contains NULL and the other type.
> This results in Schema mis-match errors for Record, Array, Enum, Fixed, and 
> Bytes.
> Here's a [review board of unit tests that express the 
> problem|https://reviews.apache.org/r/7431/], as well as one that supports the 
> case that it's only when the schema is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to