> On Aug. 22, 2012, 10:51 a.m., namit jain wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java, line > > 3903 > > <https://reviews.apache.org/r/6650/diff/2/?file=143762#file143762line3903> > > > > Is this a good idea ? > > > > Adding some API's in ObjectStore that are not to be exposed by thrift, > > and assumes a JDO.
Seems like a good idea to me. ObjectStore became JDO specific a long time ago. Also, it's important to remember that ObjectStore is just one possible implementation of the RawStore interface. We could also have (and once did have) a FileStore, or a JPAStore, etc, etc, and we don't want to expose these implementation details through a public API like the Thrift interface. - Carl ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/#review10616 ----------------------------------------------------------- On Aug. 25, 2012, 9 p.m., Shreepadma Venugopalan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6650/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2012, 9 p.m.) > > > Review request for hive and Carl Steinbach. > > > Description > ------- > > This patch implement hive metatool which, > > * lets admins perform a HA upgrade by patching the location of the NN in > Hive's metastore > * allows JDOQL to be executed against the metastore. > > > This addresses bug HIVE-3056. > https://issues.apache.org/jira/browse/HIVE-3056 > > > Diffs > ----- > > bin/ext/metatool.sh PRE-CREATION > bin/metatool PRE-CREATION > build.xml 6712af9 > conf/hive-default.xml.template cc1565f > eclipse-templates/TestHiveMetaTool.launchtemplate PRE-CREATION > metastore/ivy.xml 3011d2f > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 045b550 > metastore/src/java/org/apache/hadoop/hive/metastore/tools/HiveMetaTool.java > PRE-CREATION > metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaTool.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/6650/diff/ > > > Testing > ------- > > A new JUnit test - TestHiveMetaTool - has been added to test the various > metatool options. > > > Thanks, > > Shreepadma Venugopalan > >
