----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5504/#review8702 -----------------------------------------------------------
Looks fine overall. Perhaps we should implement setTimestamp in HivePreparedStatement. It implements setXXX() for other supported datatypes. - Prasad Mujumdar On June 21, 2012, 11:09 p.m., Richard Ding wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5504/ > ----------------------------------------------------------- > > (Updated June 21, 2012, 11:09 p.m.) > > > Review request for hive and Carl Steinbach. > > > Description > ------- > > See HIVE-2957 > > > This addresses bug HIVE-2957. > https://issues.apache.org/jira/browse/HIVE-2957 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/hive/trunk/data/files/datatypes.txt 1352206 > > http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java > 1352206 > > http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveResultSetMetaData.java > 1352206 > > http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcColumn.java > 1352206 > > http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/Utils.java > 1352206 > > http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java > 1352206 > > Diff: https://reviews.apache.org/r/5504/diff/ > > > Testing > ------- > > ant test -Dtestcase=TestJdbcDriver passed. > > > Thanks, > > Richard Ding > >
