> On June 26, 2012, 7:46 p.m., Carl Steinbach wrote: > > eclipse-templates/HiveBeeLine.launchtemplate, line 1 > > <https://reviews.apache.org/r/5554/diff/1/?file=116339#file116339line1> > > > > Please add sqlline to the eclipse classpath template in > > eclipse-files/.classpath
Done > On June 26, 2012, 7:46 p.m., Carl Steinbach wrote: > > jdbc/ivy.xml, line 36 > > <https://reviews.apache.org/r/5554/diff/1/?file=116342#file116342line36> > > > > This doesn't apply cleanly due to a change that went in a couple days > > ago. Needs a rebase. Done > On June 26, 2012, 7:46 p.m., Carl Steinbach wrote: > > jdbc/src/java/org/apache/hive/jdbc/beeline/HiveBeeline.java, line 37 > > <https://reviews.apache.org/r/5554/diff/1/?file=116343#file116343line37> > > > > Remove. Done > On June 26, 2012, 7:46 p.m., Carl Steinbach wrote: > > jdbc/src/java/org/apache/hive/jdbc/beeline/HiveBeeline.java, line 77 > > <https://reviews.apache.org/r/5554/diff/1/?file=116343#file116343line77> > > > > Remove? yes, old code. Removed > On June 26, 2012, 7:46 p.m., Carl Steinbach wrote: > > jdbc/src/java/org/apache/hive/jdbc/beeline/HiveBeeline.java, line 113 > > <https://reviews.apache.org/r/5554/diff/1/?file=116343#file116343line113> > > > > Remove. Done - Prasad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5554/#review8633 ----------------------------------------------------------- On June 25, 2012, 6:52 p.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5554/ > ----------------------------------------------------------- > > (Updated June 25, 2012, 6:52 p.m.) > > > Review request for hive and Carl Steinbach. > > > Description > ------- > > New patch for supporting SQLLine as command line editor for Hive. > LICENSE and NOTICE updates to mention SQLLine > Build changes to add SQLLine > java wrapper to translate the CLI arguments to SQLLine > > > This addresses bug HIVE-3100. > https://issues.apache.org/jira/browse/HIVE-3100 > > > Diffs > ----- > > LICENSE 05085da > NOTICE 871fdde > bin/ext/beeline.sh PRE-CREATION > eclipse-templates/HiveBeeLine.launchtemplate PRE-CREATION > ivy/ivysettings.xml fb6f4b8 > ivy/libraries.properties 8461da1 > jdbc/ivy.xml d8e3a5f > jdbc/src/java/org/apache/hive/jdbc/beeline/HiveBeeline.java PRE-CREATION > jdbc/src/java/org/apache/hive/jdbc/beeline/OptionsProcessor.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/5554/diff/ > > > Testing > ------- > > > Thanks, > > Prasad Mujumdar > >
