[ https://issues.apache.org/jira/browse/HIVE-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292485#comment-13292485 ]
Hudson commented on HIVE-3101: ------------------------------ Integrated in Hive-trunk-h0.21 #1477 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1477/]) HIVE-3101. Drop table rollback hook always called. (Ransom Hezhiqiang via egc) (Revision 1348523) Result = FAILURE ecapriolo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1348523 Files : * /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > dropTable will all ways excute hook.rollbackDropTable whether drop table > success or faild. > ------------------------------------------------------------------------------------------ > > Key: HIVE-3101 > URL: https://issues.apache.org/jira/browse/HIVE-3101 > Project: Hive > Issue Type: Bug > Components: Metastore > Reporter: ransom.hezhiqiang > Assignee: ransom.hezhiqiang > Fix For: 0.10.0 > > Attachments: HIVE-3101.1.patch > > > see the codes: > boolean success = false; > try { > client.drop_table(dbname, name, deleteData); > if (hook != null) { > hook.commitDropTable(tbl, deleteData); > } > } catch (NoSuchObjectException e) { > if (!ignoreUknownTab) { > throw e; > } > } finally { > if (!success && (hook != null)) { > hook.rollbackDropTable(tbl); > } > } > success will always false, whether the drop was success or faild. > so it's a bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira