----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5312/#review8243 -----------------------------------------------------------
ql/src/test/queries/clientpositive/udf_format_number.q <https://reviews.apache.org/r/5312/#comment17858> Each one of these queries triggers an MR job which adds time to the total test run. When possible please try to consolidate these queries into one, e.g. SELECT format_number(...) ... format_number(...) FROM src LIMIT 1; ql/src/test/queries/clientpositive/udf_format_number.q <https://reviews.apache.org/r/5312/#comment17859> Please add a note here explaining that this is actually 1 less than LONG_MAX (and one more than LONG_MIN), and include a pointer to HIVE-2733. ql/src/test/queries/clientpositive/udf_format_number.q <https://reviews.apache.org/r/5312/#comment17860> Are these values Double.MIN_VALUE and Double.MAX_VALUE? If so please add a note saying so. - Carl On 2012-05-30 23:56:23, Zhenxiao Luo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5312/ > ----------------------------------------------------------- > > (Updated 2012-05-30 23:56:23) > > > Review request for hive and Carl Steinbach. > > > Summary > ------- > > HIVE-2694. Add Format UDF > > > This addresses bug HIVE-2694. > https://issues.apache.org/jira/browse/HIVE-2694 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java d62a6b6 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFormatNumber.java > PRE-CREATION > ql/src/test/queries/clientnegative/udf_format_number_wrong1.q PRE-CREATION > ql/src/test/queries/clientnegative/udf_format_number_wrong2.q PRE-CREATION > ql/src/test/queries/clientnegative/udf_format_number_wrong3.q PRE-CREATION > ql/src/test/queries/clientnegative/udf_format_number_wrong4.q PRE-CREATION > ql/src/test/queries/clientnegative/udf_format_number_wrong5.q PRE-CREATION > ql/src/test/queries/clientnegative/udf_format_number_wrong6.q PRE-CREATION > ql/src/test/queries/clientnegative/udf_format_number_wrong7.q PRE-CREATION > ql/src/test/queries/clientpositive/udf_format_number.q PRE-CREATION > ql/src/test/results/clientnegative/udf_format_number_wrong1.q.out > PRE-CREATION > ql/src/test/results/clientnegative/udf_format_number_wrong2.q.out > PRE-CREATION > ql/src/test/results/clientnegative/udf_format_number_wrong3.q.out > PRE-CREATION > ql/src/test/results/clientnegative/udf_format_number_wrong4.q.out > PRE-CREATION > ql/src/test/results/clientnegative/udf_format_number_wrong5.q.out > PRE-CREATION > ql/src/test/results/clientnegative/udf_format_number_wrong6.q.out > PRE-CREATION > ql/src/test/results/clientnegative/udf_format_number_wrong7.q.out > PRE-CREATION > ql/src/test/results/clientpositive/show_functions.q.out 5ce8844 > ql/src/test/results/clientpositive/udf_format_number.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/5312/diff > > > Testing > ------- > > > Thanks, > > Zhenxiao > >
