[ 
https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278018#comment-13278018
 ] 

Siying Dong commented on HIVE-3030:
-----------------------------------

Here is a general problem (maybe not related to new change to this patch): 
there is no way to output "\n" back to Hive. It will be translated to a 
<new_line>. In a similar way, if the column contains "\n", it will not be 
escaped so the transform script will have no way to distinguish this from a new 
line. With this patch, more cases like this will be added. Maybe not for this 
patch but as a follow-up, we might want to escape \\ too to keep the escaping 
mapping a complete one.

Other than that, the patch looks good to me.
                
> escape more chars for script operator
> -------------------------------------
>
>                 Key: HIVE-3030
>                 URL: https://issues.apache.org/jira/browse/HIVE-3030
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to