[ 
https://issues.apache.org/jira/browse/HIVE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265492#comment-13265492
 ] 

Phabricator commented on HIVE-2986:
-----------------------------------

kevinwilfong has commented on the revision "HIVE-2986 [jira] Create the hooks".

  Sorry to nit-pick, but there's a few places where you added the license twice.

  Otherwise this looks like a good first step.  Just to confirm, this won't be 
usable until some classes are added, notably those url factories, amongst 
others.  I just want to make sure I'm not misunderstanding this.

INLINE COMMENTS
  
contrib/src/java/org/apache/hadoop/hive/ql/hooks/FbUpdateInputAccessTimeHook.java:19-35
 double license
  contrib/src/java/org/apache/hadoop/hive/ql/hooks/Triple.java:19-35 double 
license
  contrib/src/java/org/apache/hadoop/hive/ql/hooks/conf/FBHiveConf.java:19-35 
double license

REVISION DETAIL
  https://reviews.facebook.net/D2967

                
> Create hooks for new test framework
> -----------------------------------
>
>                 Key: HIVE-2986
>                 URL: https://issues.apache.org/jira/browse/HIVE-2986
>             Project: Hive
>          Issue Type: New Feature
>          Components: Testing Infrastructure
>            Reporter: Namit Jain
>         Attachments: HIVE-2986.D2967.1.patch, HIVE-2986.D2967.2.patch, 
> HIVE-2986.D2967.3.patch, HIVE-2986.D2967.4.patch, HIVE-2986.D2967.5.patch, 
> hive.2986.1.patch
>
>
> This is needed for https://issues.apache.org/jira/browse/HIVE-2985

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to