[ https://issues.apache.org/jira/browse/HIVE-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2983: ------------------------------ Attachment: HIVE-2983.D2961.1.patch travis requested code review of "HIVE-2983 [jira] Hive ant targets for publishing maven artifacts can be simplified". Reviewers: JIRA Simplify some maven-related ant tasks by using for loops. Hive has a few ant tasks related to publishing maven artifacts. As not all sub projects publish artifacts the iterate macro that simplifies other tasks cannot be used in this context. Hive already uses the for task from ant-contrib, which works great here. build.xml can be simplified by using the for task when preparing maven artifacts. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D2961 AFFECTED FILES build.xml MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/6741/ Tip: use the X-Herald-Rules header to filter Herald messages in your client. > Hive ant targets for publishing maven artifacts can be simplified > ----------------------------------------------------------------- > > Key: HIVE-2983 > URL: https://issues.apache.org/jira/browse/HIVE-2983 > Project: Hive > Issue Type: Improvement > Reporter: Travis Crawford > Assignee: Travis Crawford > Priority: Minor > Attachments: HIVE-2983.D2961.1.patch > > > Hive has a few ant tasks related to publishing maven artifacts. As not all > sub projects publish artifacts the {{iterate}} macro that simplifies other > tasks cannot be used in this context. > Hive already uses the {{for}} task from ant-contrib, which works great here. > {{build.xml}} can be simplified by using the for task when preparing maven > artifacts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira