[ https://issues.apache.org/jira/browse/HIVE-2427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261033#comment-13261033 ]
Phabricator commented on HIVE-2427: ----------------------------------- njain has commented on the revision "HIVE-2427 [jira] Warn user that precision is lost when bigint is implicitly cast to double in joins and unions.". INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:5180 This piece of code seems to be repeated - can you make a function out of it, and reuse it. ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java:198 same as above REVISION DETAIL https://reviews.facebook.net/D2181 > Warn user that precision is lost when bigint is implicitly cast to double in > joins and unions. > ---------------------------------------------------------------------------------------------- > > Key: HIVE-2427 > URL: https://issues.apache.org/jira/browse/HIVE-2427 > Project: Hive > Issue Type: Improvement > Reporter: Kevin Wilfong > Assignee: Kevin Wilfong > Attachments: HIVE-2427.1.patch.txt, HIVE-2427.2.patch.txt, > HIVE-2427.3.patch.txt, HIVE-2427.D2181.1.patch > > > When a bigint is implicitly cast to a double (when a bigint is involved in an > equality expression with a string or double as part of a join condition, or > when a bigint column is to be combined with a string or double column as part > of a union) precision may be lost, resulting in unexpected behavior. Until we > fix the underlying issue we should throw an error in strict mode, and a > warning in nonstrict mode alerting the user about this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira