[
https://issues.apache.org/jira/browse/HIVE-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-2931:
------------------------------
Attachment: HIVE-2931.D2781.1.patch
kevinwilfong requested code review of "HIVE-2931 [jira] conf settings may be
ignored".
Reviewers: JIRA
https://issues.apache.org/jira/browse/HIVE-2931
Unfortunately, Namit's patch did not pass the tests and he is away. I offer
this patch as a different solution. The issue is that before HIVE-2716, Hive
would alway have its needsRefresh set to true. Now, however, this is no longer
the case. This exposed the issue that the Hive class uses config variables
which are not metavariables. This seems perfectly reasonable, except that its
HiveConf instance is only updated if a metavariable changes. It should be
updated regardless. A metavariable changing should only determine if it needs
to connect to a new metastore instance.
This is a pretty serious problem.
If a conf variable is changed, Hive may not pick up the variable unless the
metastore variables are changed.
When any session variables are changed, it might be simpler to update the
corresponding Hive conf.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D2781
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/6309/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> conf settings may be ignored
> ----------------------------
>
> Key: HIVE-2931
> URL: https://issues.apache.org/jira/browse/HIVE-2931
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: HIVE-2931.D2781.1.patch, hive.2931.1.patch
>
>
> This is a pretty serious problem.
> If a conf variable is changed, Hive may not pick up the variable unless the
> metastore variables are changed.
> When any session variables are changed, it might be simpler to update the
> corresponding Hive conf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
