Oops, actually adding d...@fb.com this time.
On Wed, Apr 11, 2012 at 5:37 PM, John Sichi <jsi...@gmail.com> wrote: > CC'ing David Recordon, who can probably help with a point of contact > for coordinating future Phabricator upgrades. > > It looks like the test plan problem mentioned below (which affects > git, but not svn) was introduced when the reviews.facebook.net > Phabricator server was upgraded Feb 23. I've committed a change to > the arc-jira module which should deal with it: > > https://github.com/facebook/arc-jira/commit/b62b5976ec9a974ed102c2f55b530edde48cfaa5 > > So if you run ant arc-setup in your Hive sandbox, you should be good to go. > > JVS > > On Wed, Apr 11, 2012 at 3:37 PM, Carl Steinbach <c...@cloudera.com> wrote: >> Hi John, >> >>> >>> Regarding the test plans: Carl, could you be more specific about what >>> is going wrong so I can attempt to reproduce the problem? >> >> >> At some point Arc started requiring that the commit message contain a "Test >> Plan" string, or maybe this has always been a requirement and it was just >> automatically added before? Anyway, right now you have to manually add this >> or you get the following error: >> >> % git log -1 >> commit 2649ca167182bb02823b3fb00bbe7602f591717e >> Author: Carl Steinbach <c...@cloudera.com> >> Date: Wed Apr 11 15:12:53 2012 -0700 >> >> HIVE-2947. Test Phabricator >> >> % arc diff --trace --jira HIVE-2947 >> Loading phutil library 'arc_jira_lib' from >> '/Users/carl/Work/repos/hive-test/.arc_jira_lib'... >>>>> [0] <conduit> conduit.connect() >> <<< [0] <conduit> 329,414 us >>>>> [1] <exec> $ (cd '/Users/carl/Work/repos/hive-test'; git rev-parse >>>>> --show-cdup) >> <<< [1] <exec> 16,731 us >>>>> [2] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git rev-parse >>>>> --verify HEAD^) >> <<< [2] <exec> 20,879 us >>>>> [3] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git log >>>>> --first-parent --format=medium 'HEAD^'..HEAD) >> <<< [3] <exec> 17,852 us >>>>> [4] <conduit> differential.parsecommitmessage() >> <<< [4] <conduit> 558,248 us >> >> Fatal error: Uncaught exception >> 'ArcanistDifferentialCommitMessageParserException' with message 'Invalid or >> missing field 'Test Plan': You must provide a test plan.' in >> /Users/carl/.local/pkg/arcanist/src/differential/commitmessage/ArcanistDifferentialCommitMessage.php:88 >> Stack trace: >> #0 >> /Users/carl/Work/repos/hive-test/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php(88): >> ArcanistDifferentialCommitMessage->pullDataFromConduit(Object(ConduitClient)) >> #1 >> /Users/carl/Work/repos/hive-test/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php(368): >> ArcJIRAConfiguration->willRunDiffWorkflow() >> #2 /Users/carl/.local/pkg/arcanist/scripts/arcanist.php(264): >> ArcJIRAConfiguration->willRunWorkflow('diff', Object(ArcanistDiffWorkflow)) >> #3 {main} >> thrown in >> /Users/carl/.local/pkg/arcanist/src/differential/commitmessage/ArcanistDifferentialCommitMessage.php >> on line 88 >> >> Thanks. >> >> Carl >>
