[ 
https://issues.apache.org/jira/browse/HIVE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-2942:
------------------------------

    Attachment: HIVE-2942.D2727.1.patch

kevinwilfong requested code review of "HIVE-2942 [jira] substr on string 
containing UTF-8 characters produces StringIndexOutOfBoundsException".
Reviewers: JIRA

  https://issues.apache.org/jira/browse/HIVE-2942

  Fixed UDFSubstr so that for strings, the substr now succeeds if there is a 
UTF-8 character by using the string length instead of the Text length.

  Also, updated QTestUtil so that we can now write tests which include UTF-8 
characters.

  After HIVE-2792, the substr function produces a 
StringIndexOutOfBoundsException when called on a string containing UTF-8 
characters without the length argument being present.

  E.g.
  select substr(str, 1) from table1;

  now fails with that exception if str contains a UTF-8 character for any row 
in the table.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D2727

AFFECTED FILES
  ql/src/test/results/clientpositive/udf_substr.q.out
  ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java
  ql/src/test/queries/clientpositive/udf_substr.q
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSubstr.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/6219/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> substr on string containing UTF-8 characters produces 
> StringIndexOutOfBoundsException
> -------------------------------------------------------------------------------------
>
>                 Key: HIVE-2942
>                 URL: https://issues.apache.org/jira/browse/HIVE-2942
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2942.D2727.1.patch
>
>
> After HIVE-2792, the substr function produces a 
> StringIndexOutOfBoundsException when called on a string containing UTF-8 
> characters without the length argument being present.
> E.g.
> select substr(str, 1) from table1;
> now fails with that exception if str contains a UTF-8 character for any row 
> in the table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to