[
https://issues.apache.org/jira/browse/HIVE-2585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-2585:
------------------------------
Attachment: HIVE-2585.D2559.1.patch
ashutoshc requested code review of "HIVE-2585 [jira] Collapse
hive.metastore.uris and hive.metastore.local".
Reviewers: JIRA
https://issues.apache.org/jira/browse/HIVE-2585
Get rid of hive.metastore.local. By default, it was assumed to be true as a
result hive will try to connect to local metastore. That behavior is preserved
since hive.metastore.uris is empty by default.
We should just have hive.metastore.uris. If it is empty, we shall assume
local mode, if non-empty we shall use that string to connect to remote
metastore. Having two different keys for same information is confusing.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D2559
AFFECTED FILES
shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java
conf/hive-default.xml.template
metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java
metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java
metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java
metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
data/conf/hive-site.xml
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/5811/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Collapse hive.metastore.uris and hive.metastore.local
> -----------------------------------------------------
>
> Key: HIVE-2585
> URL: https://issues.apache.org/jira/browse/HIVE-2585
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: HIVE-2585.D2559.1.patch
>
>
> We should just have hive.metastore.uris. If it is empty, we shall assume
> local mode, if non-empty we shall use that string to connect to remote
> metastore. Having two different keys for same information is confusing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
